Skip to content

Update design for favourites#1998

Open
Mbeaulne wants to merge 1 commit into03-24-add_favourites_to_new_dashboardfrom
03-24-update_design_for_favourites
Open

Update design for favourites#1998
Mbeaulne wants to merge 1 commit into03-24-add_favourites_to_new_dashboardfrom
03-24-update_design_for_favourites

Conversation

@Mbeaulne
Copy link
Copy Markdown
Collaborator

Description

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

Additional Comments

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 24, 2026

🎩 To tophat this PR:

You can add the following URL parameter to your browser to tophat this PR:

`?tophat_location=03-24-update_design_for_favourites/0e56759`

@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from d40d065 to 82f814c Compare March 27, 2026 12:41
@Mbeaulne Mbeaulne force-pushed the 03-24-update_design_for_favourites branch from 9b53fca to 496e03f Compare March 27, 2026 12:41
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 82f814c to 722df94 Compare March 27, 2026 13:52
@Mbeaulne Mbeaulne force-pushed the 03-24-update_design_for_favourites branch 2 times, most recently from 2253af0 to 8301e19 Compare March 27, 2026 13:58
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 722df94 to 4746864 Compare March 27, 2026 13:58
@Mbeaulne Mbeaulne force-pushed the 03-24-update_design_for_favourites branch from 8301e19 to 8ffa88a Compare March 27, 2026 14:07
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 4746864 to 77dc4aa Compare March 27, 2026 14:07
@Mbeaulne Mbeaulne force-pushed the 03-24-update_design_for_favourites branch from 8ffa88a to dc41654 Compare March 27, 2026 14:12
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 77dc4aa to df0767f Compare March 27, 2026 14:12
@Mbeaulne Mbeaulne force-pushed the 03-24-update_design_for_favourites branch from dc41654 to 956698b Compare March 27, 2026 14:16
@Mbeaulne Mbeaulne mentioned this pull request Mar 27, 2026
3 tasks
@Mbeaulne
Copy link
Copy Markdown
Collaborator Author

Reviewer note: This is the final design for the favorites view — chips are gone, replaced with a card grid. FavoritesSection.tsx is deleted for the last time here.

DashboardFavoritesView.tsx gets one more small fix in #2001 (navigation changed from useNavigate to <Link> for correct browser behavior), but the layout and logic are stable from this PR onward.

@Mbeaulne Mbeaulne marked this pull request as ready for review March 30, 2026 18:25
@Mbeaulne Mbeaulne requested a review from a team as a code owner March 30, 2026 18:25
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from df0767f to 2c06431 Compare April 1, 2026 17:49
@Mbeaulne Mbeaulne force-pushed the 03-24-update_design_for_favourites branch 2 times, most recently from 0eccee7 to b07b0ac Compare April 1, 2026 18:34
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 2c06431 to 9a410b4 Compare April 1, 2026 18:34
@Mbeaulne Mbeaulne force-pushed the 03-24-update_design_for_favourites branch from b07b0ac to fa1e076 Compare April 1, 2026 18:37
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 8d567fe to 8ecd3d1 Compare April 1, 2026 18:42
@Mbeaulne Mbeaulne force-pushed the 03-24-update_design_for_favourites branch from fa1e076 to 502b4e5 Compare April 1, 2026 18:42
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 8ecd3d1 to 8f2572b Compare April 2, 2026 16:35
@Mbeaulne Mbeaulne force-pushed the 03-24-update_design_for_favourites branch 3 times, most recently from f4f5ee3 to 1c50d84 Compare April 2, 2026 16:53
@Mbeaulne Mbeaulne force-pushed the 03-24-add_favourites_to_new_dashboard branch from 2fad661 to 856d5ab Compare April 2, 2026 19:19
@Mbeaulne Mbeaulne force-pushed the 03-24-update_design_for_favourites branch from 1c50d84 to 0e56759 Compare April 2, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant